core(i18n): import psuedo-locale json from TC #5726
Conversation
There was a problem hiding this comment.
also want to update https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/lib/locales/index.js
and should
lighthouse/lighthouse-cli/cli-flags.js
Lines 122 to 125 in e99673b
be based on
Object.keys(require('...../locales/index.js'))?
found another TC export script that has an option for hyphen rather than underscore. So this is a common thing. :) Since our build script also prefers hyphen i guess we should go with that.. |
paulirish
force-pushed
the
importxcjson2
branch
2 times, most recently
from
48d4206
to
de7623d
Compare
|
running lighthouse -GA --preset=perf http://example.com --locale=en-XAI currently get this: should I address it in this PR? |
:/ ya the extra locales will be useless if we can't actually generate reports with them |
|
ready for review. lighthouse --preset=perf --locale=ar-XB http://example.com/
lighthouse --preset=perf --locale=en-XA http://example.com/
|
|
🏏 🏏 |
| @@ -58,7 +58,8 @@ describe('i18n', () => { | |||
| describe('#getRendererFormattedStrings', () => { | |||
| it('returns icu messages in the specified locale', () => { | |||
| const strings = i18n.getRendererFormattedStrings('en-XA'); | |||
| expect(strings.passedAuditsGroupTitle).toEqual('P̂áŝśêd́ âúd̂ít̂ś'); | |||
| expect(strings.passedAuditsGroupTitle).toEqual('[Þåššéð åûðîţš one two]'); | |||
| expect(strings.scorescaleLabel).toEqual('[Šçöŕé šçåļé: one two]'); | |||
There was a problem hiding this comment.
we should probably convert this file back to assert at some point rather than having a different assertion library just for this file
There was a problem hiding this comment.
nooooooooooooo 😢 assert is so sad compared to expect
updated